Skip to content

revert the behavior of making IntelliSense and Q suggestions co-exist #5353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 11, 2025
Merged

revert the behavior of making IntelliSense and Q suggestions co-exist #5353

merged 7 commits into from
Feb 11, 2025

Conversation

@andrewyuq
Copy link
Contributor

@andrewyuq andrewyuq commented Feb 10, 2025 •
edited
Loading

Effectively reverting the logic of making both suggestions co-exist,

Caveats:

  1. the CodeWhispererPopupIntelliSenseAcceptListener is still added but not invoked because no lookup will be available when seeing Q suggestions

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@andrewyuq andrewyuq requested a review from a team as a code owner February 10, 2025 23:15
@manodnyab
Copy link
Contributor

manodnyab commented Feb 10, 2025

can you please add a changelog?

@andrewyuq andrewyuq requested a review from a team as a code owner February 10, 2025 23:25
@andrewyuq andrewyuq enabled auto-merge (squash) February 10, 2025 23:43
@andrewyuq andrewyuq merged commit a766f62 into aws:main Feb 11, 2025
11 of 13 checks passed
samgst-amazon pushed a commit that referenced this pull request Feb 12, 2025
@andrewyuq @samgst-amazon
revert the behavior of making IntelliSense and Q suggestions co-exist (…
e707fb2 
…#5353)

* revert the behavior of making IntelliSense and Q suggestions co-exist

* change log

* Remove isQPrioritizedForTabAccept usage

* fix typing
gandhi-21 pushed a commit to gandhi-21/aws-toolkit-jetbrains that referenced this pull request Feb 26, 2025
@andrewyuq
revert the behavior of making IntelliSense and Q suggestions co-exist (…
601b6d8 
…aws#5353)

* revert the behavior of making IntelliSense and Q suggestions co-exist

* change log

* Remove isQPrioritizedForTabAccept usage

* fix typing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Will-ShaoHua Will-ShaoHua Will-ShaoHua approved these changes

@manodnyab manodnyab manodnyab approved these changes

@rli rli Awaiting requested review from rli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewyuq @manodnyab @Will-ShaoHua